[FFmpeg-cvslog] r16776 - trunk/libavutil/mem.c

Reimar Döffinger Reimar.Doeffinger
Sun Jan 25 19:10:06 CET 2009


On Sun, Jan 25, 2009 at 07:05:57PM +0100, Reimar D?ffinger wrote:
> On Sun, Jan 25, 2009 at 06:36:48PM +0100, diego wrote:
> > Author: diego
> > Date: Sun Jan 25 18:36:48 2009
> > New Revision: 16776
> > 
> > Log:
> > Do not #include common.h without necessity.
> > This eliminates the need to work around common.h overriding certain system
> > functions which are required in this header.
> 
> And how is that supposed to work when someone includes common.h before
> mem.h? Both are part of the public API.

How silly of me, I did not see this is mem.c, not mem.h.
It does lead to another question, why is mem.h not included in mem.c?
IMO it should be, because then mismatches in the function declarations
result in a compile error instead of possibly runtime bugs.

Greetings,
Reimar D?ffinger




More information about the ffmpeg-cvslog mailing list