[FFmpeg-cvslog] r16823 - trunk/libavcodec/arm/dsputil_arm_s.S

[Reimar Döffinger]

On Wed, Jan 28, 2009 at 10:43:33AM +0000, M?ns Rullg?rd wrote:
> Reimar D?ffinger <Reimar.Doeffinger at stud.uni-karlsruhe.de> writes:
> > On Tue, Jan 27, 2009 at 05:25:23PM +0000, M?ns Rullg?rd wrote:
> >> Reimar D?ffinger <Reimar.Doeffinger at stud.uni-karlsruhe.de> writes:
> >> > On Tue, Jan 27, 2009 at 05:06:51PM +0100, mru wrote:
> >> >> Author: mru
> >> >> Date: Tue Jan 27 17:06:51 2009
> >> >> New Revision: 16823
> >> >> 
> >> >> Log:
> >> >> ARM: reorder some instructions in put_pixels*_arm
> >> >
> >> > I think a log message is supposed to contain the why (faster, more
> >> > readable, ...?)
> >> 
> >> Such changes are always for speed.
> >
> > That is a very broad statement, I am sure that someone somewhere has
> > modified some assembler code for some other reason.
> > And I did think that there was consensus that commit messages should
> > provide information beyond what the diff tells, this one definitely
> > doesn't, it hardly qualifies even as a summary since it is not much
> > shorter than the diff.
> 
> And since when do YOU care the slightest about commit messages?  You
> are usually among the most vigorous protesters when asked to write
> descriptive messages.  So shut up already.

Huh? Are you confusing me with someone? I think I always was in favour
of commit messages that allow every developer to get an idea of what the
effects of a patch are.
I am of course against a one-page prose in a commit message, since
reading the commit message is supposed to be much faster way to get an
idea than reading the patch.
And do you disagree that "ARM: reorder some instructions in
put_pixels*_arm to increase speed" would be more helpful?
Maybe you considered it obvious that was the reason for the change, but
now you know that it wasn't at least for two of us.
Note that I am not asking you to provide benchmark numbers or anything
in the commit message.
While I did try to abstract it so it applies to commit messages in
general ("a log message is supposed to contain the why") I was
mainly trying to point out that I did not know what the purpose of your
change was supposed to be, and wanted you to clarify (preferably by
changing the commit message).
Since you certainly know the "why" it should not be a big deal for you to
add it to the commit message (of course you are allowed to forget things
sometimes :-) ), and since you (IMHO rightly) complain when someone
breaks ARM optimizations I think I have the right to complain when I
think you make it unnecessarily hard for us to understand those
optimizations/changes to them.

Greetings,
Reimar D?ffinger