[FFmpeg-cvslog] r19091 - trunk/libavcodec/4xm.c

Baptiste Coudurier baptiste.coudurier
Sat Jun 6 08:28:41 CEST 2009

On 6/5/2009 1:10 PM, Michael Niedermayer wrote:
> On Fri, Jun 05, 2009 at 10:12:14AM +0200, bcoudurier wrote:
>> Author: bcoudurier
>> Date: Fri Jun  5 10:12:14 2009
>> New Revision: 19091
>> Log:
>> 4xm decoder uses get_buffer, set CODEC_CAP_DR1
> i think you broke several decoders with these changes, no i dont
> know which but

Well, technically I don't think this breaks any decoder. It may break
applications which set get_buffer based on CODEC_CAP_DR1 flag.

This might be a problem indeed.

However I tested a very naive implementation of get_buffer within
ffmpeg, see patch attached and 4xm decoder seems to work fine.

About linesize == width*bpp, this seems mandatory for packet pixfmt.

Anything obvious I'm missing ?

Baptiste COUDURIER                              GnuPG Key Id: 0x5C1ABAAA
Key fingerprint                 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA
FFmpeg maintainer                                  http://www.ffmpeg.org
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: test_get_buffer.patch
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-cvslog/attachments/20090605/43eea1ec/attachment.asc>

More information about the ffmpeg-cvslog mailing list