[FFmpeg-cvslog] r19173 - trunk/libavformat/adtsenc.c

Ronald S. Bultje rsbultje
Sat Jun 20 17:32:25 CEST 2009


2009/6/12 M?ns Rullg?rd <mans at mansr.com>

> Alex Converse <alex.converse at gmail.com> writes:
> > 2009/6/12 M?ns Rullg?rd <mans at mansr.com>:
> >> alexc <subversion at mplayerhq.hu> writes:
> >>> -        ff_log_missing_feature(s, "Signaled SBR or PS", 0);
> >>> +        av_log(s, AV_LOG_ERROR, "Signaled SBR or PS is not
> supported\n");
> >>
> >> Why did you do that?
> >
> > libavformat lacks ff_log_missing_feature
> Why can't it call the lavc one?  It already depends on lavc.
> This is internal.h crackdown is getting silly.

Let's fix this - I have the same issue and don't want the above.
ff_log_missing_feature() is undoubtedly useful to both lavc and lavf, but
shouldn't be used outside. Can we agree that lavf/lavc/sws are allowed to
access lavu/internal and that lavf is allowed to access lavc/internal.h
(easiest solution, since it requires no patch), or can we somehow agree on
an alternative header to contain stuff that we want to access from depending
modules within, but not outside lav* (external.h? :-) j/k, but name
suggestions are welcome)?


More information about the ffmpeg-cvslog mailing list