[FFmpeg-cvslog] r17873 - in trunk: ffmpeg.c libavformat/audiointerleave.c libavutil/fifo.c

Reimar Döffinger Reimar.Doeffinger
Mon Mar 9 00:39:23 CET 2009


On Sun, Mar 08, 2009 at 11:40:46PM +0100, Michael Niedermayer wrote:
> On Sun, Mar 08, 2009 at 03:43:51PM +0100, Reimar D?ffinger wrote:
> > On Sun, Mar 08, 2009 at 03:42:11PM +0100, reimar wrote:
> > > Author: reimar
> > > Date: Sun Mar  8 15:42:11 2009
> > > New Revision: 17873
> > > 
> > > Log:
> > > Replace all uses of the replaced av_fifo_read by av_fifo_generic_read
> > 
> > Btw. is it intentional/is there a rationale behind the different order
> > of parameters for av_fifo_generic_read and av_fifo_generic_write?
> 
> not that i remember but IMHO dst & context should be on the left.

I guess it is because depending on how you see it, it is not dst but an
argument to the function.
Should I reorder it into context, dest, buf_size, func? Or is there too
much risk of confusing everyone and so not worth doing?




More information about the ffmpeg-cvslog mailing list