[FFmpeg-cvslog] r17909 - trunk/libavformat/rmdec.c

[Kostya]

On Mon, Mar 09, 2009 at 11:35:45AM -0400, Ronald S. Bultje wrote:
> Hi,
> 
> On Mon, Mar 9, 2009 at 10:45 AM, Michael Niedermayer <michaelni at gmx.at> wrote:
> > who has reviewed and approved this patch?
> 
> Well, all these patches have been posted, some of them _long_ ago.
> Anyway, I'll revert the last two tonight after I finish work.
> 
> The one that you're commenting on here was posted in the thread named
> in the subject, so Kostya, please go ahead and review it. :-). I agree
> with you that eventually the ff_rm_parse_packet() should be done
> independently of the setup of the function arguments, but would like
> to do the two in separate patches.

Will try to re-review them today.
 
> The second of these two (the remaining_len one [1]) is correct and a
> potential security issue (negative integer overflow), so I'd still
> like Kostya or you to re-review that patch and OK it so I can
> re-commit it. I've tested it on valid files using remaining_len (any
> video file) and the output is identical.
> 
> Ronald
> 
> [1] http://article.gmane.org/gmane.comp.video.ffmpeg.devel/79566