[FFmpeg-cvslog] r17909 - trunk/libavformat/rmdec.c

Kostya kostya.shishkov
Mon Mar 9 18:55:37 CET 2009


On Mon, Mar 09, 2009 at 01:46:32PM +0100, rbultje wrote:
> Author: rbultje
> Date: Mon Mar  9 13:46:32 2009
> New Revision: 17909
> 
> Log:
> Replace separate packet parsing for "old_format" .ra files by a call to
> ff_rm_parse_packet(). See "[PATCH] Make RM demuxer behave better with -an
> option" thread, which sort-of turned into an aggregate of unrelated rmdec.c
> cleanups.
> 
> Modified:
>    trunk/libavformat/rmdec.c
 
This one seems to be a good candidate to revert.
Why? Because common code is not factored out well enough (i.e. packet reading).
Also it won't work in many cases when you stop demuxing first subpacket inside
ff_rm_parse_packet().
Please revert and submit a new patch following the scheme I've described earlier. 





More information about the ffmpeg-cvslog mailing list