[FFmpeg-cvslog] r17967 - trunk/libavformat/mxfenc.c

[Reimar Döffinger]

On Sat, Mar 14, 2009 at 11:43:29PM +0100, bcoudurier wrote:
> Author: bcoudurier
> Date: Sat Mar 14 23:43:28 2009
> New Revision: 17967
> 
> Log:
> do not parse timestamp if bitexact is set, should fix regression tests

(trying hard to hold my tongue on using localtime in general)
There is not much sense on using localtime() and then storing that value
when the time_t value is 0 (which is the default value).
I am also not sure if users are particularly happy that even when they
don't want FFmpeg to write a time stamp their time zone setting ends up
encoded in the file (unless they use bit-exact).
Or to make it short: I think CODEC_FLAG_BITEXACT is the wrong condition
(I don't think it is a great idea to misuse it as a
"we_are_running_regression_tests" flag), s->timestamp would have been
the right one, but at least it should be checked in addition.