[FFmpeg-cvslog] r18005 - trunk/libavformat/rmdec.c

Måns Rullgård mans
Mon Mar 16 21:57:22 CET 2009


"Ronald S. Bultje" <rsbultje at gmail.com> writes:

> Hi,
>
> 2009/3/16 M?ns Rullg?rd <mans at mansr.com>:
>> s->streams[i] with uninitialised i is a bad idea...
>
> Even if I don't use the result?
>
> s->streams[i] is just s->streams + i, so an (undefined, random)

No, it's *(s->streams + i).

> address. As long as I don't use it (i.e. access
> s->streams[i]->something", I don't actually access (read from) the
> "random" resulting address and thus it shouldn't matter, right?

Think about the memory layout of the different structs and about what
addresses the pointers hold.

-- 
M?ns Rullg?rd
mans at mansr.com




More information about the ffmpeg-cvslog mailing list