[FFmpeg-cvslog] r18249 - trunk/libavcodec/vaapi.h

Diego Biurrun diego
Mon Mar 30 23:18:17 CEST 2009


On Mon, Mar 30, 2009 at 08:33:10PM +0200, Michael Niedermayer wrote:
> On Mon, Mar 30, 2009 at 05:37:00PM +0200, diego wrote:
> > 
> > Log:
> > Add required va/va.h header, should fix 'make checkheaders'.
> > 
> > --- trunk/libavcodec/vaapi.h	Mon Mar 30 15:29:10 2009	(r18248)
> > +++ trunk/libavcodec/vaapi.h	Mon Mar 30 17:36:59 2009	(r18249)
> > @@ -25,6 +25,7 @@
> >  
> >  #include <stdint.h>
> > +#include <va/va.h>
> 
> This is not a possible solution, please revert
> The interface between lavc and the player MUST NOT depend on such headers.

Clearly, the right solution is not to revert this.  "VABufferID" is used
from that header.  A proper solution is up to Gwenole.  Until then this
serves to remind of the fact that the header has issues.

You should really rethink your dislike or checkheaders.  It is very
useful to detect such subtle bugs which could otherwise go unnoticed for
years.

Diego



More information about the ffmpeg-cvslog mailing list