[FFmpeg-cvslog] r18743 - in trunk/libavcodec: avcodec.h options.c

[Baptiste Coudurier]

Hi Michael,

On 5/5/2009 11:25 AM, michael wrote:
> Author: michael
> Date: Tue May  5 20:25:20 2009
> New Revision: 18743
> 
> Log:
> Add colorspace fields to AVCodecContext.

First of all this is very nice, thanks for the work.

>  
> +enum AVColorPrimaries{
> +    AVCOL_PRI_BT709      =1, ///< also ITU-R BT1361 / IEC 61966-2-4 / SMPTE RP177 Annex B
> +    AVCOL_PRI_UNSPECIFIED=2,
> +    AVCOL_PRI_BT470M     =4,
> +    AVCOL_PRI_BT470BG    =5, ///< also ITU-R BT601-6 625 / ITU-R BT1358 625 / ITU-R BT1700 625 PAL & SECAM
> +    AVCOL_PRI_SMPTE170M  =6, ///< also ITU-R BT601-6 525 / ITU-R BT1358 525 / ITU-R BT1700 NTSC
> +    AVCOL_PRI_SMPTE240M  =7, ///< functionally identical to above
> +    AVCOL_PRI_FILM       =8,
> +    AVCOL_PRI_NB           , ///< Not part of ABI
> +};

Question does this map in some way what can be stored in mpeg-2 ?
Is this why we duplicate 6/7 ?

Wouldn't it be better to use BT601 name directly instead ? I reckon
people are more familiar with this name and 709 now in HD.

Does h.264 use these values in some way too ?

[...]

-- 
Baptiste COUDURIER                              GnuPG Key Id: 0x5C1ABAAA
Key fingerprint                 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA
checking for life_signs in -lkenny... no
FFmpeg maintainer                                  http://www.ffmpeg.org