[FFmpeg-cvslog] r20518 - trunk/ffplay.c

[Baptiste Coudurier]

On 11/11/2009 04:03 PM, Uoti Urpala wrote:
> On Wed, 2009-11-11 at 15:52 -0800, Baptiste Coudurier wrote:
>> On 11/11/2009 03:51 PM, Diego Biurrun wrote:
>>> On Wed, Nov 11, 2009 at 03:47:08PM -0800, Baptiste Coudurier wrote:
>
>>>> Are applications supposed to include "config.h" ?
>>>
>>> ffserver.c and ffmpeg.c already do it.  All three use definitions from
>>> config.h all over the place...
>>
>> I'm worried since it's supposed to be an example on how to use the
>> libraries.
>
> Applications would usually include their *own* config.h or equivalent.
> FFmpeg applications share one with the libraries.

Well, maybe it's time to distinguish applications from libraries 
configuration.

>> IMHO we should once and for all clean the mess and make the symbols not
>> part of the API _invisible_.
>
> Visibility support would be good, but I think it's mostly orthogonal to
> config.h definitions.

I thought config.h was required for some definitions, in this case it's 
not orthogonal.

-- 
Baptiste COUDURIER
Key fingerprint                 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA
FFmpeg maintainer                                  http://www.ffmpeg.org