[FFmpeg-cvslog] r20497 - trunk/configure
Sun Nov 15 07:58:12 CET 2009
On Nov 14, 2009, at 10:38 PM, M?ns Rullg?rd wrote:
> Alexander Strange <astrange at ithinksw.com> writes:
>> On Nov 10, 2009, at 7:57 AM, reimar wrote:
>>> Author: reimar
>>> Date: Tue Nov 10 13:57:28 2009
>>> New Revision: 20497
>>> Check if PIC is somehow already enabled (e.g. a compiler that enables it by default).
>>> This in particular ensures that -DPIC is set appropriately for YASM, which avoids
>>> linking failures on x86_64 for compilers that have PIE enabled by default
>>> (e.g. hardened Gentoo).
>>> It also makes the macho64 special-case hack adding -DPIC to YASMFLAGS obsolete.
>> This broke adding -mdynamic-no-pic on Darwin again.
> Can you please explain what the problem is?
The compiler defaults to PIC, so that check runs 'enable pic'.
After that, -mdynamic-no-pic, which turns it off again, is under ! 'enabled_any pic shared', so it's not added.
Maybe it shouldn't be using the same variable for PIC being detected and the user specifically requesting it, but that won't fix this check, which either needs to not run for Darwin or to run after the flag is added.
>> Is it safe to move the check after the OS section?
> I'm not sure.
> M?ns Rullg?rd
> mans at mansr.com
> ffmpeg-cvslog mailing list
> ffmpeg-cvslog at mplayerhq.hu
More information about the ffmpeg-cvslog