[FFmpeg-cvslog] r20552 - trunk/libavcodec/mjpegdec.c

Reimar Döffinger Reimar.Doeffinger
Fri Nov 20 15:57:59 CET 2009

On Fri, Nov 20, 2009 at 02:21:53PM +0100, Michael Niedermayer wrote:
> I dont think this is correct
> The test should be s->height % (s->v_max*8)
> besides this the fliped code also looks suspect

Hmm. Does anyone actually have or can create a sample that should be flipped
and where the height is not divisible by 8 or so?
Either way, I am quite confident that the check here should be exactly
for the same thing as whatever is used for the flipping code.
I suspect that your code is more correct, however I also think that
the 8*mb_height is completely bogus and should have particularly funny
effects if someone created a lossless JPEG (where mb_width is never
initialized) that somehow triggers flipped.

More information about the ffmpeg-cvslog mailing list