[FFmpeg-cvslog] r20225 - trunk/libavcodec/w32thread.c

[Reimar Döffinger]

On Tue, Oct 13, 2009 at 03:41:38PM +0200, Benoit Fouet wrote:
> On 2009-10-13 15:40, reimar wrote:
> > Author: reimar
> > Date: Tue Oct 13 15:40:03 2009
> > New Revision: 20225
> > 
> > Log:
> > Implement execute2 for w32thread
> > 
> > Modified:
> >    trunk/libavcodec/w32thread.c
> > 
> > Modified: trunk/libavcodec/w32thread.c
> > ==============================================================================
> > --- trunk/libavcodec/w32thread.c	Tue Oct 13 15:03:12 2009	(r20224)
> > +++ trunk/libavcodec/w32thread.c	Tue Oct 13 15:40:03 2009	(r20225)
> > @@ -32,10 +32,12 @@ typedef struct ThreadContext{
> >      HANDLE job_sem;
> >      HANDLE done_sem;
> >      int (*func)(AVCodecContext *c, void *arg);
> > +    int (*func2)(AVCodecContext *c, void *arg, int, int);
> 
> could you add a name for the last two arguments to this function
> pointer, so that it is a little less obscure (and more consistent with
> what exists) ?

I can, it was just thinking about asking about this, if we shouldn't
instead add a typedef for it and properly document things once there
instead of having it duplicated and the documentation munged into the
AVCodecContext.execute/execute2 doxy.
Does anyone else have an opinion (and/or name suggestion)?