[FFmpeg-cvslog] r20419 - trunk/libavfilter/vf_null.c

[Michael Niedermayer]

On Fri, Oct 30, 2009 at 12:11:25PM +0100, stefano wrote:
> Author: stefano
> Date: Fri Oct 30 12:11:25 2009
> New Revision: 20419
> 
> Log:
> Remove the get_video_buffer() callback.
> 
> That was never required since avfilter_get_video_buffer() already
> calls itself on the next link if get_video_buffer is not defined.

Please send patches before commiting to avfilter, avfilter is complex,
its easy to mess up.
also its not true that this was never required, rather your r20272
change made it unneeded and iam pretty sure this part of r20272 is
going to bite us
id rataher revert r20419 and part of r20272 becuase as is a filter with
2 outputs will send buffers allocated by output 0 down a random path,
and these may be hardware buffers that are very limited.
the buffer should only ever be taken from the output if it is also
send back to that output later.
limiting the code from r20272 to output_count==1 and documenting the
default behavior is probably the least that has to be done. That is
this is a critical thing every filter author must check
[Do i pass buffers through? if not i MUST overide get_video_buffer
 because the default passes allocates through behind my back]
before r20272 it was
[Do i pass buffers through? if so i SHOULD overide get_video_buffer]



[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Old school: Use the lowest level language in which you can solve the problem
            conveniently.
New school: Use the highest level language in which the latest supercomputer
            can solve the problem without the user falling asleep waiting.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-cvslog/attachments/20091030/d3e7b575/attachment.pgp>