[FFmpeg-cvslog] r20057 - in trunk: Makefile tests/codec-regression.sh

[Diego Biurrun]

On Sun, Sep 27, 2009 at 12:33:25PM +0200, Stefano Sabatini wrote:
> On date Sunday 2009-09-27 11:08:35 +0100, M?ns Rullg?rd wrote:
> > Reimar D?ffinger <Reimar.Doeffinger at gmx.de> writes:
> > 
> > > On Sun, Sep 27, 2009 at 11:33:37AM +0200, stefano wrote:
> > >> +function do_lavfi() {
> > >
> > > Where did you get the idea of using function? It breaks FATE.
> > 
> > Probably from some silly bash manual.
> 
> Yes most of us learn sh by learning bash, then there is the common
> habit of writing non-portable bash scripts. The problem here is bash
> not complaining of the use of the "function" keyword when invoked like
> "sh".

I suggest using bash just as interactive shell, but not as /bin/sh.
That will catch such mistakes.  It will also make your system faster,
provide you with good karma, improve your general health and earn you
respect among your peers.  Do it ;)

Diego