[FFmpeg-cvslog] r22667 - in trunk/libavformat: httpauth.c httpauth.h

Ronald S. Bultje rsbultje
Sat Apr 3 00:09:29 CEST 2010


Hi,

On Fri, Apr 2, 2010 at 5:55 PM, Daniel Verkamp <daniel at drv.nu> wrote:
> On Thu, Mar 25, 2010 at 8:58 AM, mstorsjo <subversion at mplayerhq.hu> wrote:
>> + ? ?/* Generate a client nonce. */
>> + ? ?for (i = 0; i < 2; i++)
>> + ? ? ? ?cnonce_buf[i] = ff_random_get_seed();
>> + ? ?ff_data_to_hex(cnonce, (const uint8_t*) cnonce_buf, sizeof(cnonce_buf), 1);
>
>> + ? ?cnonce[2*sizeof(cnonce_buf)] = 0;
>
> GCC warns that this is out of array bounds, and I think it is right:
> 2*sizeof(cnonce_buf) = 16, but cnonce is only 9 entries long.

Fixed.

Ronald



More information about the ffmpeg-cvslog mailing list