[FFmpeg-cvslog] r22937 - in trunk: libavcodec/amrnbdec.c libavcodec/atrac1.c libavcodec/audioconvert.c libavcodec/qcelpdata.h libavcodec/qcelpdec.c libavcodec/ra288.c libavcodec/sipr.c libavcodec/sipr16k.c libavco...

Michael Niedermayer michaelni
Mon Apr 26 00:04:07 CEST 2010


On Sun, Apr 25, 2010 at 12:56:18PM -0400, Ronald S. Bultje wrote:
> Hi,
> 
> 2010/4/25 M?ns Rullg?rd <mans at mansr.com>:
> > "Ronald S. Bultje" <rsbultje at gmail.com> writes:
> >> ?static inline av_const int32_t av_clipl_int32(int64_t a)
> >> ?{
> >> - ? ?if ((a+2147483648) & ~2147483647) return (a>>63) ^ 2147483647;
> >> + ? ?if ((a+0x80000000U) & ~INT64_C(0xFFFFFFFF)) return (a>>63) ^ 0x7FFFFFFF;
> >> ? ? ?else ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?return a;
> >> ?}
> >
> > I prefer writing the u suffix in lowercase, as that makes it visually
> > more distinct from the digits.
> >
> > Please use UINT64_C to avoid any surprises from bitwise operations on
> > signed numbers.
> 
> Both fixed.
> 
> Ronald

>  common.h |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 5d9eac3782a574b9d0a506034c872c4605589685  clip.patch

assuming everyone is done with the bikeshedding, patch ok

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

When the tyrant has disposed of foreign enemies by conquest or treaty, and
there is nothing more to fear from them, then he is always stirring up
some war or other, in order that the people may require a leader. -- Plato
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-cvslog/attachments/20100426/726042ef/attachment.pgp>



More information about the ffmpeg-cvslog mailing list