[FFmpeg-cvslog] r25931 - trunk/libavformat/asfdec.c

Michael Niedermayer michaelni
Wed Dec 15 14:46:34 CET 2010

On Wed, Dec 15, 2010 at 08:20:07AM +0100, Reimar D?ffinger wrote:
> On Wed, Dec 15, 2010 at 01:43:03AM +0100, Michael Niedermayer wrote:
> > On Tue, Dec 14, 2010 at 09:41:39PM +0100, Reimar D?ffinger wrote:
> > > On Tue, Dec 14, 2010 at 12:21:20PM -0800, Baptiste Coudurier wrote:
> > > > >Sorry, I considered it "obvious". The ASF demuxer did not check the
> > 
> > uhm, maybe iam stupid but i had read your mail to mean that not this but the
> > previous commit caused the regression and for that it would not have been
> > obvious whats going on
> Ah, ok. My mail sure wasn't that well-written.
> > > > Did somebody change his mind ?
> > > 
> > > No. It's just that in this specific case it is a pain to do because the
> > > demuxer needs to juggle the data around and that's not something you
> > > can do if you have only half of it.
> > > And I am too lazy to think about if and when you could still do
> > > something reasonable.
> > 
> > then the end of the packet can be filled with zeros.
> > we seem to be loosing significant portions of valid audio with this and i
> > dont think this is good
> I really don't like making up data, also the amount of audio lost is not
> sufficient to actually hear the difference (well, for me).
> Though I admit I really wouldn't mind a nicer solution, especially since
> I think the descrambling code in some cases is a NOP.

if the descrambling is not a NOP random bytes in the middle of a packet are lost
some audio codecs are designed to handle this, its annoying if the packet is
droped IMHO

> Problem is just it takes extra time to come up with a solution I'd consider
> good and I don't have that much time I'd like to spend on this...

thats ok but i think then you should leave the code as it was if you lack time
and not commit a hack

Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Many that live deserve death. And some that die deserve life. Can you give
it to them? Then do not be too eager to deal out death in judgement. For
even the very wise cannot see all ends. -- Gandalf
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-cvslog/attachments/20101215/bb7da667/attachment.pgp>

More information about the ffmpeg-cvslog mailing list