[FFmpeg-cvslog] r26033 - trunk/libavcodec/ac3enc.c

Justin Ruggles justin.ruggles
Mon Dec 20 23:44:51 CET 2010

On 12/20/2010 05:33 PM, Ronald S. Bultje wrote:

> Hi,
> On Mon, Dec 20, 2010 at 5:30 PM, Justin Ruggles
> <justin.ruggles at gmail.com> wrote:
>> All of the configurations which failed after this revision are x86.
> Is it possible that one of the optimized functions on these platforms,
> which isn't tested otherwise, is causing this? E.g. consider that
> float-to-int routines require different float values depending on
> optimization level...

I tried all x86 versions of sad[0] (C, MMX, MMX2, SSE2) and they passed
on my system, so I don't think there is anything fundamentally wrong
with how ac3enc is using sad[0].

>> Unrelated to this (but still concerning FATE failures), the ARM and
>> AVR32 configurations did not like the previous ac3 encoder changes.  The
>> output size is the same, but the checksums differ.  My best guess is
>> that it is related to the lrintf() in the float-to-int conversion for
>> the sin/cos tables.  I could remove the lrintf() but I don't think it's
>> a good idea.  Alternatively, I could hardcode the tables like is done
>> for the MDCT window and that would probably fix it.
> That's what the float off-by-one tests are for...

How does one enable this for an audio encoding regression test?


More information about the ffmpeg-cvslog mailing list