[FFmpeg-cvslog] r21833 - trunk/libavcodec/aac.c

Reimar Döffinger Reimar.Doeffinger
Mon Feb 15 20:11:58 CET 2010


On Mon, Feb 15, 2010 at 11:23:55AM -0500, Alex Converse wrote:
> > @@ -324,7 +324,7 @@ static int decode_pce(AACContext *ac, en
> > ?*
> > ?* @return ?Returns error status. 0 - OK, !0 - error
> > ?*/
> > -static int set_default_channel_config(AACContext *ac,
> > +static av_cold int set_default_channel_config(AACContext *ac,
> > ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? enum ChannelPosition new_che_pos[4][MAX_ELEM_ID],
> > ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? int channel_config)
> > ?{
> 
> As far as reindenting goes the parameter lists are already very far
> right. Thoughts?

Bikeshed issue, but just indent them by e.g. 8 characters on the next line.
It doesn't help readability any to have the arguments all the way to the right,
and the only purpose of the whole alignment is readability.



More information about the ffmpeg-cvslog mailing list