[FFmpeg-cvslog] r21917 - trunk/libavutil/internal.h

[Måns Rullgård]

cehoyos <subversion at mplayerhq.hu> writes:

> Author: cehoyos
> Date: Sat Feb 20 13:22:24 2010
> New Revision: 21917
>
> Log:
> Gcc attribute may_alias is not supported (or silently ignored) by all supported compilers.
>
> Modified:
>    trunk/libavutil/internal.h
>
> Modified: trunk/libavutil/internal.h
> ==============================================================================
> --- trunk/libavutil/internal.h	Sat Feb 20 12:22:47 2010	(r21916)
> +++ trunk/libavutil/internal.h	Sat Feb 20 13:22:24 2010	(r21917)
> @@ -56,7 +56,7 @@
>  #endif
>
>  #ifndef av_alias
> -#if HAVE_ATTRIBUTE_MAY_ALIAS
> +#if HAVE_ATTRIBUTE_MAY_ALIAS && (!defined(__ICC) || __ICC > 1110) && AV_GCC_VERSION_AT_LEAST(3,3)
>  #   define av_alias __attribute__((may_alias))
>  #else
>  #   define av_alias

Did I approve this?  Did anyone else approve this?  No on both accounts.

Is this a mess?  Is this wrong?  Yes on both accounts.

In fact, your hack changes *nothing* for the compilers you seem to be
talking about.  ICC 11.1 still doesn't support this attribute, and
most other compilers claim to be gcc 4.2 or higher.  This does disable
it for gcc 2.95, but that's about the extent of it.  What were you thinking?

-- 
M?ns Rullg?rd
mans at mansr.com