[FFmpeg-cvslog] r21071 - trunk/libavformat/rtsp.c

[Diego Biurrun]

On Thu, Jan 07, 2010 at 11:41:14PM +0100, rbultje wrote:
> 
> Log:
> Reformat.

Can we have a slightly more informative message please?

Also, this is not just reformatting.

> --- trunk/libavformat/rtsp.c	Thu Jan  7 23:33:26 2010	(r21070)
> +++ trunk/libavformat/rtsp.c	Thu Jan  7 23:41:14 2010	(r21071)
> @@ -101,23 +101,24 @@ static int sdp_parse_rtpmap(AVCodecConte
>  
>      if (payload_type >= RTP_PT_PRIVATE) {
> -        RTPDynamicProtocolHandler *handler= RTPFirstDynamicPayloadHandler;
> -        while(handler) {
> -            if (!strcasecmp(buf, handler->enc_name) && (codec->codec_type == handler->codec_type)) {
> -                codec->codec_id = handler->codec_id;
> -                rtsp_st->dynamic_handler= handler;
> -                if(handler->open) {
> -                    rtsp_st->dynamic_protocol_context= handler->open();
> -                }
> +        RTPDynamicProtocolHandler *handler;
> +        for (handler = RTPFirstDynamicPayloadHandler;
> +             handler; handler = handler->next) {
> +            if (!strcasecmp(buf, handler->enc_name) &&
> +                codec->codec_type == handler->codec_type) {
> +                codec->codec_id          = handler->codec_id;
> +                rtsp_st->dynamic_handler = handler;
> +                if (handler->open)
> +                    rtsp_st->dynamic_protocol_context = handler->open();
>                  break;
>              }
> -            handler= handler->next;
>          }

What did you do there?  Whatever it is, it's more than reformatting.

Do you look at your diff?  I spotted this in less than two seconds.

So what do you do differently.  I have a hunch there are two things
we do differently:

- You seem not to know how to filter out whitespace changes from the
  output of svn diff, read the help again (hint: -x -uwb).
- You seem to start from a tree with random changes.  Use a fresh
  one instead.  It's impossible to mess up from a fresh tree.

Diego