[FFmpeg-cvslog] r23976 - in trunk: libavcodec/aacdec.c libavcodec/acelp_pitch_delay.h libavcodec/cook.c libavcodec/escape124.c libavcodec/fraps.c libavcodec/lsp.h libavcodec/qdm2.c libavdevice/x11grab.c libavforma...

[Michael Niedermayer]

On Fri, Jul 02, 2010 at 02:31:49PM +0200, Diego Biurrun wrote:
> On Fri, Jul 02, 2010 at 02:04:11PM +0200, Michael Niedermayer wrote:
> > On Fri, Jul 02, 2010 at 01:19:30PM +0200, diego wrote:
> > > 
> > > Log:
> > > Remove non-existing stray arguments from Doxygen function documentation.
> > > 
> > > --- trunk/libavcodec/lsp.h	Fri Jul  2 13:13:23 2010	(r23975)
> > > +++ trunk/libavcodec/lsp.h	Fri Jul  2 13:19:29 2010	(r23976)
> > > @@ -48,7 +48,6 @@ void ff_acelp_reorder_lsf(int16_t* lsfq,
> > >   *
> > >   * @param[in,out] lsf    LSFs in Hertz
> > >   * @param min_spacing    minimum distance between two consecutive lsf values
> > > - * @param                size size of the lsf vector
> > >   */
> > >  void ff_set_min_dist_lsf(float *lsf, double min_spacing, int order);
> > 
> > the implementation looks like this:
> > void ff_set_min_dist_lsf(float *lsf, double min_spacing, int size)
> 
> Fixed.

let me repeat, please revert the commit. Noone has reviewed it and your
recent commits are so broken that revert is the only sensible choice.
Also i as leader ask you a 2nd time now, refrain from further commits
to the code documentation! you are not qualified you are not a C expert
like you may be a english expert.
If you want to change the code documentation you can post patches that
will be reviewed by the C developers.

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Republics decline into democracies and democracies degenerate into
despotisms. -- Aristotle
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-cvslog/attachments/20100702/f5a66c92/attachment.pgp>