[FFmpeg-cvslog] r24156 - trunk/configure

Reimar Döffinger Reimar.Doeffinger
Sat Jul 10 15:08:45 CEST 2010

On Sat, Jul 10, 2010 at 12:15:50PM +0100, M?ns Rullg?rd wrote:
> Reimar D?ffinger <Reimar.Doeffinger at gmx.de> writes:
> > WTF? This has not the slightest bit to do with this change.
> The change replaced a check for x86_64 with a different check.

Yes, and the x86_64 check was a pathetic way to detect MinGW64

> > The change is about avoiding an incorrect
> > die "ERROR: MinGW runtime version must be >= 3.15."
> > When compiling a 32 bit binary using mingw-w64 headers.
> When compiling a 32-bit binary, "enabled x86_64" should never be
> true.  The change only makes any sense at all if x86_64 is incorrectly
> enabled at some point.

No, the issue is that it is _correctly_ _disabled_

> >> >> > -        if ! enabled x86_64; then
> >> >> > +        if ! check_cpp_condition _mingw.h "defined (__MINGW64_VERSION_MAJOR)"; then

If x86_64 was _correctly_ _disabled_ then the mingw_32_ version check would
run even on mingw-w_64_, and fail.

More information about the ffmpeg-cvslog mailing list