[FFmpeg-cvslog] r23039 - in trunk/libavfilter: vsrc_buffer.c vsrc_buffer.h

[Michael Niedermayer]

On Sat, Jul 17, 2010 at 08:28:54PM +0100, M?ns Rullg?rd wrote:
> Michael Niedermayer <michaelni at gmx.at> writes:
> 
> >> The file could also use a stdint.h #include.
> >
> > thats unneeded from what i remember
> > stdint.h or inttypes is amongth the ones included by avfilter/avutil/... 
> > main header which we include already.
> 
> There is no promise this will remain the case. 

its certain that inttypes or stdint will be included by the main headers
because their types are used by the public api all over the place.


> All files should
> include whatever headers they need directly, even if one happens to
> be indirectly included by another.

i faintly remember you saying you didnt mind the main headers or common.h
being used instead of repeating the standard includes in them in every
file. but maybe i misremember or it was someone else ...

either way, litterally the rule of "All files should
include whatever headers they need directly, even if one happens to
be indirectly included by another."

Is not implementable unless you provide a automated way to detect such
missing includes. Thats besides the wasted time enforcing such rule
would lead to and it might also slow compilation down with some compilers.

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Its not that you shouldnt use gotos but rather that you should write
readable code and code with gotos often but not always is less readable
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-cvslog/attachments/20100718/36a8b2bb/attachment.pgp>