[FFmpeg-cvslog] r24443 - trunk/libavcodec/vp8.c

Reimar Döffinger Reimar.Doeffinger
Fri Jul 23 18:27:41 CEST 2010

On Fri, Jul 23, 2010 at 03:37:30AM -0700, Jason Garrett-Glaser wrote:
> On Fri, Jul 23, 2010 at 3:34 AM, Carl Eugen Hoyos <cehoyos at ag.or.at> wrote:
> > Carl Eugen Hoyos <cehoyos <at> ag.or.at> writes:
> >
> >> If you feel your time is too precious to remove cosmetic changes from your
> >> patches, please just post them on -devel, I am sure there are enough people
> >> being happy to apply them (including me).
> >
> > Another possibility that I forgot is to simply apply the patch without the
> > cosmetics, other developers (and I) have fixed it in the past without
> > complaining.
> "Cosmetics"?  Indentation is not cosmetics, it is part of the code.
> Anything that provides information to the reader of the code (human or
> compiler) is *by definition* not cosmetics.

Then I guess nothing is cosmetics. A rather pointless definition of the word.
Also, for this project indentation as far as I know has always been considered
cosmetics, in so far as it should be done separately.

> I am not going to do extra work for every single patch I submit just
> to satisfy your insane definition of "cosmetics" for code you don't
> even maintain!

That is a rather funny argument to make for code that you ended up reindenting
twice for no change at all in the end.
You could have saved both yourself and everyone trying to follow your work and
maybe learn something a bit of time by not reindenting at first.
And yes, learning things is one of the main reasons for me to follow this project,
and your style of committing is close to making understanding and learning from
your changes a waste of time for me.
And no, manually doing diff -w is not a substitute, it costs extra time and
needs a SVN checkout and internet connection (or a git checkout).

More information about the ffmpeg-cvslog mailing list