[FFmpeg-cvslog] r31772 - trunk/libswscale/swscale.h

Stefano Sabatini stefano.sabatini-lala
Sun Jul 25 11:58:33 CEST 2010

On date Saturday 2010-07-24 14:45:51 +0200, Michael Niedermayer wrote:
> On Fri, Jul 23, 2010 at 01:01:31AM +0200, stefano wrote:
> > Author: stefano
> > Date: Fri Jul 23 01:01:31 2010
> > New Revision: 31772
> > 
> > Log:
> > Prefer impersonal form over third person, for consistency with the
> > rest of FFmpeg.
> you are not a native english person, so at the least this
> should have been submitted as patch and checked by someone who is a
> native english speaker

That's why I find silly the native englis person review rule. What we
need is a set of written conventions to follow, there is no sense into
demanding a "native English person" to review the patch if the rule to
follow are clear enough (and we don't have so much review man-power,
so the less we demand the better it is).

Also let me note that this "native english person rule" sounds like a
discrimination, especially considering that most FFmpeg devs are *not*
native English speakers, the "nativeness" has little to do with the
competence in the area of English grammar/composition and of the
stylistic conventions to be used in the FFmpeg code.

I'd rather prefer to have a documentation maintainer, which is choosen
for his competence in the abovementioned areas, which *may* be an
English native speaker, which "cleans-up after the fact", and which
occasionally reviews/flames on lists.

And again note that *this* change has nothing to do with
grammar/English language, but with mere stylistic conventions (already
thoroughly discussed in depth), thus I see no need for an English
expert review.


More information about the ffmpeg-cvslog mailing list