[FFmpeg-cvslog] r23646 - in trunk/libavcodec: mpegaudio.h mpegaudiodec.c

Michael Niedermayer michaelni
Sat Jun 19 20:53:43 CEST 2010


On Sat, Jun 19, 2010 at 03:33:50PM +0200, Vitor Sessak wrote:
> On 06/19/2010 01:13 PM, M?ns Rullg?rd wrote:
>> vitor<subversion at mplayerhq.hu>  writes:
[...]
>>> @@ -2227,7 +2262,11 @@ static int mp_decode_frame(MPADecodeCont
>>>       for(ch=0;ch<s->nb_channels;ch++) {
>>>           samples_ptr = samples + ch;
>>>           for(i=0;i<nb_frames;i++) {
>>> -            
>>> RENAME(ff_mpa_synth_filter)(s->synth_buf[ch],&(s->synth_buf_offset[ch]),
>>> +            RENAME(ff_mpa_synth_filter)(
>>> +#if CONFIG_FLOAT
>>> +                         s,
>>> +#endif
>>
>> Do I really need to tell you that this is hideously ugly?
>
> No, that's why I was expecting some suggestion ;)

you could wait with applying before the patch is approved
anyway, you can pass s to the fixed point one too if you
benchmark it and its not meassuerably slower

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

There will always be a question for which you do not know the correct awnser.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-cvslog/attachments/20100619/66df73c1/attachment.pgp>



More information about the ffmpeg-cvslog mailing list