[FFmpeg-cvslog] r22288 - trunk/libavcodec/avcodec.h

[Måns Rullgård]

Michael Niedermayer <michaelni at gmx.at> writes:

> On Sun, Mar 07, 2010 at 10:16:44PM +0100, alexc wrote:
>> Author: alexc
>> Date: Sun Mar  7 22:16:44 2010
>> New Revision: 22288
>> 
>> Log:
>> Increase FF_INPUT_BUFFER_PADDING_SIZE to 64.
>> 
>> The purpose of this is to give decoders a reasonable amount of buffer to work
>> with before needing to check for overreads.
>
> breaks ABI, and is wrong, as the padding needed by some codecs for fast
> overread detection is too much for small frame codecs like *celp ...
>
> IMHO
> 1. revert this
> 2. replace all memset(FF_INPUT_BUFFER_PADDING_SIZE) by AV_ZERO32()
> 3. add a field to AVCodec that specifies the required padding for each decoder
> 4. replace all alloc(FF_INPUT_BUFFER_PADDING_SIZE) by that field from 3.

Since this is a real problem with potential security implications, can
we please go ahead and do this soon, major version bump be damned?  We
already have quite a number of changes queued up for the next bump,
and doing it before the 0.6 release seems like a good idea.

-- 
M?ns Rullg?rd
mans at mansr.com