[FFmpeg-cvslog] r23009 - trunk/libavcodec/avcodec.h

[Michael Niedermayer]

On Mon, May 03, 2010 at 06:47:28PM +0200, Reimar D?ffinger wrote:
> On Mon, May 03, 2010 at 01:27:56PM +0200, Michael Niedermayer wrote:
> > On Sun, May 02, 2010 at 06:07:30PM +0200, reimar wrote:
> > > Author: reimar
> > > Date: Sun May  2 18:07:29 2010
> > > New Revision: 23009
> > > 
> > > Log:
> > > Clarify how allocation works for the picture argument for
> > > avcodec_decode_video3.
> > > 
> > > Modified:
> > >    trunk/libavcodec/avcodec.h
> > > 
> > > Modified: trunk/libavcodec/avcodec.h
> > > ==============================================================================
> > > --- trunk/libavcodec/avcodec.h	Sat May  1 23:05:28 2010	(r23008)
> > > +++ trunk/libavcodec/avcodec.h	Sun May  2 18:07:29 2010	(r23009)
> > > @@ -3464,6 +3464,8 @@ attribute_deprecated int avcodec_decode_
> > >   *
> > >   * @param avctx the codec context
> > >   * @param[out] picture The AVFrame in which the decoded video frame will be stored.
> > > + *             Use avcodec_alloc_frame to get an AVFrame, the codec will call
> > 
> > > + *             get_buffer to get memory for the actual image data.
> > 
> > not all codecs will
> 
> Well, I think there are only 2 exception, schroedinger and qtrleenc.

no, there are more


> And I thought the idea was that they should use get_buffer as well
> (though only work with the default ones that do whatever special tricks
> necessary).

some decoders require linesize to have a special value for a clean
implementation.

you could look at kgv1dec.c and eatgv.c they seem 2 more that dont use
get_buffer()


> What would you prefer?
> ", the codec will itself allocate the memory for the actual image data."

maybe "bitmap" is a better term maybe worse ...


> Maybe add a "(e.g. via get_buffer)"?

its still not guranteed
besides there is reget_buffer() too


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Dictatorship naturally arises out of democracy, and the most aggravated
form of tyranny and slavery out of the most extreme liberty. -- Plato
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-cvslog/attachments/20100504/832bb083/attachment-0001.pgp>