[FFmpeg-cvslog] r23119 - trunk/libavcodec/mpegaudiodec.c

[Michael Niedermayer]

On Thu, May 13, 2010 at 07:55:32PM +0100, M?ns Rullg?rd wrote:
> Alex Converse <alex.converse at gmail.com> writes:
> 
> > Had you not exercised your prerogative to just commit this all at
> > once,
> 
> I'd argue he doesn't, or at any rate shouldn't, have that right.
> Everybody else is expected to post new codecs for review.  Michael
> should be no exception.

iam the maintainer of the code
noone would have reviewed it anyway
the change was quite trivial
ill look into the issues people raise in case some do
in how far this can be considered a new codec is debateable
besides and this is most imporant IMO, we should not throw strange
stuff in the way of advancing ffmpeg.
Maintainers must be able to maintain their code or people will just
keep their changes in their private forks (this is happening already)
its not good. Review is intended to find problems in design, bugs and
so on and have them corrected as well as helping developers who are
unsure on how to solve an issue.  Review is not intended to drag down
development and hamper code maintaince.
Having a repository where multiple people have write access requires
a bit of diplomacy and cooperation between people. And i think
some people are a bit too quick in attacking others lately. And also
in a way that lacks all style and politeness.

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The educated differ from the uneducated as much as the living from the
dead. -- Aristotle 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-cvslog/attachments/20100513/61ecaf98/attachment.pgp>