[FFmpeg-cvslog] r23119 - trunk/libavcodec/mpegaudiodec.c

Måns Rullgård mans
Thu May 13 22:15:10 CEST 2010


Michael Niedermayer <michaelni at gmx.at> writes:

> On Thu, May 13, 2010 at 07:55:32PM +0100, M?ns Rullg?rd wrote:
>> Alex Converse <alex.converse at gmail.com> writes:
>> 
>> > Had you not exercised your prerogative to just commit this all at
>> > once,
>> 
>> I'd argue he doesn't, or at any rate shouldn't, have that right.
>> Everybody else is expected to post new codecs for review.  Michael
>> should be no exception.
>
> iam the maintainer of the code

Yes.  That doesn't make you immune to mistakes.

> noone would have reviewed it anyway

You don't know that.

> the change was quite trivial

It broke several FATE machines.

> ill look into the issues people raise in case some do

So far you only complained about the tablegen code.  Someone else
fixed the problem.

You have yet to respond to any of my comments.

> in how far this can be considered a new codec is debateable

It adds several AVCodec instances.

> besides and this is most imporant IMO, we should not throw strange
> stuff in the way of advancing ffmpeg.

Is it really that hard to post a patch and wait a few hours before
committing stuff?

> Maintainers must be able to maintain their code or people will just
> keep their changes in their private forks (this is happening already)
> its not good. Review is intended to find problems in design, bugs and
> so on and have them corrected as well as helping developers who are
> unsure on how to solve an issue.  Review is not intended to drag down
> development and hamper code maintaince.

Then why do you apply much stricter rules to others than you do to
yourself?  That is mainly what I take issue with.

-- 
M?ns Rullg?rd
mans at mansr.com



More information about the ffmpeg-cvslog mailing list