[FFmpeg-cvslog] r23322 - trunk/libavcodec/aaccoder.c

[Alex Converse]

2010/5/25 M?ns Rullg?rd <mans at mansr.com>:
> Alex Converse <alex.converse at gmail.com> writes:
>
>> 2010/5/25 M?ns Rullg?rd <mans at mansr.com>:
>>> Alex Converse <alex.converse at gmail.com> writes:
>>>
>>>> 2010/5/25 M?ns Rullg?rd <mans at mansr.com>:
>>>>> Alex Converse <alex.converse at gmail.com> writes:
>>>>>
>>>>>> On Tue, May 25, 2010 at 7:12 PM, Aurelien Jacobs <aurel at gnuage.org> wrote:
>>>>>>> Mixed declaration and code...
>>>>>>>
>>>>>>
>>>>>> Fixed.
>>>>>>
>>>>>> Why is this considered bad?
>>>>>
>>>>> I personally consider it bad style. ?Practically, there are a number
>>>>> of compiler that choke on it but otherwise work decently.
>>>>
>>>> Practically it's not that hard to extend your compiler to support it.
>>>
>>> Have you ever tried hacking compilers? ?Closed-source ones?
>>
>> Yes. I've hacked some closed derivatives of suif.
>>
>>> Making it good style is of course much harder...
>>
>> Putting the declaration closer to where the code is actually used
>> seems much more readable to me.
>
> If that makes a difference, your blocks are way too long to begin with.
>

Patches welcome