[FFmpeg-cvslog] r25385 - trunk/libavformat/mpegenc.c

[Diego Biurrun]

On Thu, Oct 07, 2010 at 12:24:15PM +0200, Michael Niedermayer wrote:
> On Wed, Oct 06, 2010 at 08:16:20PM -0700, Alex Converse wrote:
> > On Wed, Oct 6, 2010 at 6:57 PM, michael <subversion at mplayerhq.hu> wrote:
> > >
> > > Log:
> > > Warn if muxing mpeg ps is attempted without a VBV buffer size.
> > >
> > > --- trunk/libavformat/mpegenc.c Thu Oct ?7 03:57:35 2010 ? ? ? ?(r25384)
> > > +++ trunk/libavformat/mpegenc.c Thu Oct ?7 03:57:39 2010 ? ? ? ?(r25385)
> > > @@ -367,8 +367,10 @@ static int mpeg_mux_init(AVFormatContext
> > > ? ? ? ? ? ? if (st->codec->rc_buffer_size)
> > > ? ? ? ? ? ? ? ? stream->max_buffer_size = 6*1024 + st->codec->rc_buffer_size/8;
> > > - ? ? ? ? ? ?else
> > > + ? ? ? ? ? ?else{
> > 
> > Just two days ago people asked you to put whitespace after keywords.
> 
> yes and iam not doing it, you should vote on me being leader accordingly.

The attitude you show when criticized...

> also IMHO, the one who said it loud enough for me to remember it at all is
> diego (on the phone ;) ) and he
> neither maintains C code nor is he contributing C code. And this is stuff
> that should be decided by the people falling in these 2 categories

Except of course for Stefano two days ago.  And who would dare to
criticize you when you immediately threaten to kill the critic or
yourself?

> IMHO such whitespace cosmetics go too far and ive never asked others to
> follow such nitpickery. Especially not if they feel strongly about it

You do nitpick people about vertical alignment.

I'll also have to note that K&R style is mandated in the developer
guidelines.  But those guidelines are just something you use to
smack people over the head, not something you feel bound by
yourself.

Diego