[FFmpeg-cvslog] r25575 - trunk/libavcodec/vp3.c

darkshikari subversion
Tue Oct 26 09:37:51 CEST 2010


Author: darkshikari
Date: Tue Oct 26 09:37:51 2010
New Revision: 25575

Log:
Remove dead code in theora_decode_tables
Reading 7 bits as an unsigned int can't result in a value exceeding 127.
Accordingly, remove error message (as it'll never be reached).

Modified:
   trunk/libavcodec/vp3.c

Modified: trunk/libavcodec/vp3.c
==============================================================================
--- trunk/libavcodec/vp3.c	Tue Oct 26 09:30:01 2010	(r25574)
+++ trunk/libavcodec/vp3.c	Tue Oct 26 09:37:51 2010	(r25575)
@@ -2052,15 +2052,9 @@ static int theora_decode_tables(AVCodecC
     if (s->theora >= 0x030200) {
         n = get_bits(gb, 3);
         /* loop filter limit values table */
-        if (n) {
-            for (i = 0; i < 64; i++) {
+        if (n)
+            for (i = 0; i < 64; i++)
                 s->filter_limit_values[i] = get_bits(gb, n);
-                if (s->filter_limit_values[i] > 127) {
-                    av_log(avctx, AV_LOG_ERROR, "filter limit value too large (%i > 127), clamping\n", s->filter_limit_values[i]);
-                    s->filter_limit_values[i] = 127;
-                }
-            }
-        }
     }
 
     if (s->theora >= 0x030200)



More information about the ffmpeg-cvslog mailing list