[FFmpeg-cvslog] r25128 - in trunk: configure libavcodec/libmp3lame.c

Måns Rullgård mans
Thu Sep 16 00:15:39 CEST 2010


cehoyos <subversion at mplayerhq.hu> writes:

> @@ -61,7 +61,8 @@ static av_cold int MP3lame_encode_init(A
>      if(avctx->flags & CODEC_FLAG_QSCALE) {
>          lame_set_brate(s->gfp, 0);
>          lame_set_VBR(s->gfp, vbr_default);
> -        lame_set_VBR_q(s->gfp, avctx->global_quality / (float)FF_QP2LAMBDA);
> +        /* requires lame 3.98 or later */
> +        lame_set_VBR_quality(s->gfp, avctx->global_quality/(float)FF_QP2LAMBDA);

Why did you include that useless comment?  Imagine what it would look
like if every function call had a comment like that beside it.

-- 
M?ns Rullg?rd
mans at mansr.com



More information about the ffmpeg-cvslog mailing list