[FFmpeg-cvslog] Move the info union to the end of the vdpau_render_state struct.

Reimar Döffinger Reimar.Doeffinger at gmx.de
Wed Apr 20 20:14:31 CEST 2011


On Wed, Apr 20, 2011 at 09:44:54AM +0200, Carl Eugen Hoyos wrote:
> diff --git a/libavcodec/vdpau.h b/libavcodec/vdpau.h
> index ab5f682..0dc6fb8 100644
> --- a/libavcodec/vdpau.h
> +++ b/libavcodec/vdpau.h
> @@ -67,6 +67,13 @@ struct vdpau_render_state {
>  
>      int state; ///< Holds FF_VDPAU_STATE_* values.
>  
> +    /** Describe size/location of the compressed video data.
> +        Set to 0 when freeing bitstream_buffers. */
> +    int bitstream_buffers_allocated;
> +    int bitstream_buffers_used;
> +    /** The user is responsible for freeing this buffer using av_freep(). */
> +    VdpBitstreamBuffer *bitstream_buffers;
> +
>      /** picture parameter information for all supported codecs */
>      union VdpPictureInfo {
>          VdpPictureInfoH264        h264;
> @@ -74,13 +81,6 @@ struct vdpau_render_state {
>          VdpPictureInfoVC1          vc1;
>          VdpPictureInfoMPEG4Part2 mpeg4;
>      } info;

Maybe add a comment here that while adding more members might be possible
without breaking the API/ABI, that might then block adding more codecs.
Possibly the union should in such a case be grown via padding first.


More information about the ffmpeg-cvslog mailing list