[FFmpeg-cvslog] WMADEC: fix ticket125

[Michael Niedermayer]

On Thu, Apr 28, 2011 at 01:55:31PM +0300, Ivan Kalvachev wrote:
> On 4/27/11, Michael Niedermayer <git at videolan.org> wrote:
> > ffmpeg | branch: master | Michael Niedermayer <michaelni at gmx.at> | Wed Apr
> > 27 17:12:14 2011 +0200| [f08d171caa6a8eab00c1b0ac87bb3a79d98727e5] |
> > committer: Michael Niedermayer
> >
> > WMADEC: fix ticket125
> 
> Once again, write more descriptive messages.

theres not all that much i can say here, its trying to fix wma decoder
issues by trial and error. (make change that works with all my samples
and wait to see is users report an issue)


> 
> Be sure to answer the 2 question : What do you fix, and how do you fix it.

what: decoder failure
how: the one line change shows as much as i know.


> 
> It requires a lot more effort to find out what ticket125 says. Don't
> forget that we referred to bugs with roundup issues, and we kind of
> lost the whole roundup database.
> 

> About "How" - in this case I can see that there is changed condition,
> but I have no idea what the old one was supposed to do and I have no
> idea what the new one is checking.

I dont know either
beyond "it works"

i could use a disassembler but its too much work for this or i could
ask microsoft but i dont think they will tell me ;)

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The worst form of inequality is to try to make unequal things equal.
-- Aristotle
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-cvslog/attachments/20110429/efd56130/attachment.asc>