[FFmpeg-cvslog] Do not ignore opt_default() return values.

Carl Eugen Hoyos git at videolan.org
Mon Aug 1 01:03:04 CEST 2011


ffmpeg | branch: master | Carl Eugen Hoyos <cehoyos at ag.or.at> | Mon Aug  1 00:36:52 2011 +0200| [8460b757c2c20b57d1dd1c1989086f942a261b4b] | committer: Carl Eugen Hoyos

Do not ignore opt_default() return values.

> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=8460b757c2c20b57d1dd1c1989086f942a261b4b
---

 ffmpeg.c |   12 ++++--------
 1 files changed, 4 insertions(+), 8 deletions(-)

diff --git a/ffmpeg.c b/ffmpeg.c
index cc8fdd2..2a1ee79 100644
--- a/ffmpeg.c
+++ b/ffmpeg.c
@@ -3030,8 +3030,7 @@ static int opt_qscale(const char *opt, const char *arg)
 static int opt_top_field_first(const char *opt, const char *arg)
 {
     top_field_first = parse_number_or_die(opt, arg, OPT_INT, 0, 1);
-    opt_default(opt, arg);
-    return 0;
+    return opt_default(opt, arg);
 }
 
 static int opt_thread_count(const char *opt, const char *arg)
@@ -3077,15 +3076,13 @@ static int opt_audio_channels(const char *opt, const char *arg)
 static int opt_video_channel(const char *opt, const char *arg)
 {
     av_log(NULL, AV_LOG_WARNING, "This option is deprecated, use -channel.\n");
-    opt_default("channel", arg);
-    return 0;
+    return opt_default("channel", arg);
 }
 
 static int opt_video_standard(const char *opt, const char *arg)
 {
     av_log(NULL, AV_LOG_WARNING, "This option is deprecated, use -standard.\n");
-    opt_default("standard", arg);
-    return 0;
+    return opt_default("standard", arg);
 }
 
 static int opt_codec(const char *opt, const char *arg)
@@ -4379,8 +4376,7 @@ static void log_callback_null(void* ptr, int level, const char* fmt, va_list vl)
 static int opt_passlogfile(const char *opt, const char *arg)
 {
     pass_logfilename_prefix = arg;
-    opt_default("passlogfile", arg);
-    return 0;
+    return opt_default("passlogfile", arg);
 }
 
 static const OptionDef options[] = {



More information about the ffmpeg-cvslog mailing list