[FFmpeg-cvslog] crypto: fix potential double free

Etienne Buira etienne.buira.lists at free.fr
Wed Jun 8 22:59:23 CEST 2011


On Wed, Jun 08, 2011 at 02:26:19AM +0200, Etienne Buira wrote:
> ffmpeg | branch: master | Etienne Buira <etienne.buira.lists at free.fr> | Wed Jun  8 02:20:53 2011 +0200| [7d89f7cbf3ccd98f9a5f58db97effa9afd2d571a] | committer: Michael Niedermayer
> 
> crypto: fix potential double free
> 
> > http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=7d89f7cbf3ccd98f9a5f58db97effa9afd2d571a

Hi.

Please revert, Martin and Ronald pointed mistakes, a better replacement
will come from libav.org.

While I was at it, I had a look at av_freep use through the tree, and
found one similar issue as I did, which can be &ed, or replaced by
av_free.
-------------- next part --------------
diff --git a/ffserver.c b/ffserver.c
index ab16aa7..c31a54b 100644
--- a/ffserver.c
+++ b/ffserver.c
@@ -1366,7 +1366,7 @@ static void free_acl_list(IPAddressACL *in_acl)
     while(pacl) {
         pacl2 = pacl;
         pacl = pacl->next;
-        av_freep(pacl2);
+        av_freep(&pacl2);
     }
 }
 


More information about the ffmpeg-cvslog mailing list