[FFmpeg-cvslog] build: Remove redundant config.mak includes from subdirectory Makefiles.

Reimar Döffinger Reimar.Doeffinger at gmx.de
Sun Jun 26 13:33:11 CEST 2011


On Sun, Jun 26, 2011 at 01:22:07PM +0200, Stefano Sabatini wrote:
> On date Sunday 2011-06-26 09:40:46 +0200, Reimar Döffinger wrote:
> > On Sun, Jun 26, 2011 at 02:39:26AM +0200, Diego Biurrun wrote:
> > > ffmpeg | branch: master | Diego Biurrun <diego at biurrun.de> | Sat Jun 25 00:19:39 2011 +0200| [a6213f3dce4006e0d47bd938e15832987d95efef] | committer: Diego Biurrun
> > > 
> > > build: Remove redundant config.mak includes from subdirectory Makefiles.
> > > 
> > > Calling Make from subdirectories is not supported and config.mak has
> > > multiple inclusion guards anyway, so the top-level include is enough.
> > 
> 
> > Am I really the only one who cares about this feature?
> > I don't mind maintaining it, however if such obviously breaking changes
> > get merged immediately and it'll end up broken most of the time, plus
> > with git revert not properly working reverting it is far more effort
> > than not merging it feels like it will be nothing more than a waste
> > of time...
> 
> I care about the "calling make from subdirectories" feature, and I
> honestly have no idea why it was removed in the first place (but I see
> there is a tendency to oversimplify things there).

Ok. I do understand it to some degree, it involves some ugliness
but I'd consider it acceptable.
I admit I've never done git merges so I also want to apologize to
Michael in case it seems like I attacked him, it's just that the
"merge and then revert" workflow is extra work and error-prone
so I just would prefer to avoid it.


More information about the ffmpeg-cvslog mailing list