[FFmpeg-cvslog] rv34: fix signed multiplication overflow

Mans Rullgard git at videolan.org
Sun Nov 27 00:39:12 CET 2011


ffmpeg | branch: master | Mans Rullgard <mans at mansr.com> | Sat Nov 26 14:50:23 2011 +0000| [171ec812235a5d22fa421242351ee2da5a96c3ba] | committer: Mans Rullgard

rv34: fix signed multiplication overflow

Multiply by unsigned 0x01010101 to replicate bytes into 32-bit
word.

Signed-off-by: Mans Rullgard <mans at mansr.com>

> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=171ec812235a5d22fa421242351ee2da5a96c3ba
---

 libavcodec/rv34.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/libavcodec/rv34.c b/libavcodec/rv34.c
index 091d49f..098f7b5 100644
--- a/libavcodec/rv34.c
+++ b/libavcodec/rv34.c
@@ -933,7 +933,7 @@ static void rv34_pred_4x4_block(RV34DecContext *r, uint8_t *dst, int stride, int
         if(itype == VERT_LEFT_PRED) itype = VERT_LEFT_PRED_RV40_NODOWN;
     }
     if(!right && up){
-        topleft = dst[-stride + 3] * 0x01010101;
+        topleft = dst[-stride + 3] * 0x01010101u;
         prev = (uint8_t*)&topleft;
     }
     r->h.pred4x4[itype](dst, prev, stride);



More information about the ffmpeg-cvslog mailing list