[FFmpeg-cvslog] qdm2: fix signed multiplication overflow

Mans Rullgard git at videolan.org
Thu Oct 13 06:01:45 CEST 2011


ffmpeg | branch: master | Mans Rullgard <mans at mansr.com> | Tue Oct 11 17:45:55 2011 +0100| [c682514a8f17a886f31c5aa0bba78c4f260fbfcf] | committer: Mans Rullgard

qdm2: fix signed multiplication overflow

This code relies on the result wrapping as for unsigned
values, and the sign is not used.  Thus an unsigned type
is proper here.

Signed-off-by: Mans Rullgard <mans at mansr.com>

> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=c682514a8f17a886f31c5aa0bba78c4f260fbfcf
---

 libavcodec/qdm2_tablegen.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/libavcodec/qdm2_tablegen.h b/libavcodec/qdm2_tablegen.h
index b2bb294..bb73d92 100644
--- a/libavcodec/qdm2_tablegen.h
+++ b/libavcodec/qdm2_tablegen.h
@@ -90,7 +90,7 @@ static av_cold void rnd_table_init(void) {
 
 static av_cold void init_noise_samples(void) {
     int i;
-    int random_seed = 0;
+    unsigned random_seed = 0;
     float delta = 1.0 / 16384.0;
     for (i = 0; i < 128;i++) {
         random_seed = random_seed * 214013 + 2531011;



More information about the ffmpeg-cvslog mailing list