[FFmpeg-cvslog] Move av_tempfile() into libavutil, it is a generically usefull thing and its small.
michaelni at gmx.at
Sun Oct 16 22:40:28 CEST 2011
On Sun, Oct 16, 2011 at 10:28:33PM +0200, Reimar Döffinger wrote:
> On 16 Oct 2011, at 22:16, Michael Niedermayer <michaelni at gmx.at> wrote:
> > On Sun, Oct 16, 2011 at 09:42:12PM +0200, Reimar Döffinger wrote:
> >> On Sun, Oct 16, 2011 at 09:35:26PM +0200, Michael Niedermayer wrote:
> >>> On Sun, Oct 16, 2011 at 09:22:11PM +0200, Reimar Döffinger wrote:
> >>>> On Sun, Oct 16, 2011 at 05:21:22PM +0200, Michael Niedermayer wrote:
> >>>>> - fd = open(*filename, O_RDWR | O_BINARY | O_CREAT, 0444);
> >>>> Adding O_EXCL should increase security here.
> >>>> Seems supported at least on Linux and Windows.
> >>>> Might fail compilation on some systems though.
> >>> fixed locally
> >> Oh, and did you fix the 0444 mode? That seems both like
> >> a bad idea and mismatches mkstemp behaviour.
> > fixed locally, anything else that needs fixing?
> Nothing beyond me still having a really bad feeling about this code for now at least.
if you prefer we can move it back to libavcodec and require a flag
for the cache protocol somehow
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
Incandescent light bulbs waste a lot of energy as heat so the EU forbids them.
Their replacement, compact fluorescent lamps, much more expensive, dont fit in
many old lamps, flicker, contain toxic mercury, produce a fraction of the light
that is claimed and in a unnatural spectrum rendering colors different than
in natural light. Ah and we now need to turn the heaters up more in winter to
compensate the lower wasted heat. Who wins? Not the environment, thats for sure
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 198 bytes
Desc: Digital signature
More information about the ffmpeg-cvslog