[FFmpeg-cvslog] dsputil: set STRIDE_ALIGN to 16 for x86 also.

Michael Niedermayer michaelni at gmx.at
Fri Feb 10 20:50:39 CET 2012


On Fri, Feb 10, 2012 at 08:27:11AM +0100, Reimar Döffinger wrote:
> On 10 Feb 2012, at 01:19, Michael Niedermayer <michaelni at gmx.at> wrote:
> > On Thu, Feb 09, 2012 at 11:28:49PM +0100, Michael Niedermayer wrote:
> >> On Thu, Feb 09, 2012 at 09:14:38PM +0100, Reimar Döffinger wrote:
> >>> On Thu, Feb 09, 2012 at 01:46:09AM +0100, Ronald S. Bultje wrote:
> >>>> ffmpeg | branch: master | Ronald S. Bultje <rsbultje at gmail.com> | Tue Feb  7 14:54:46 2012 -0800| [9b027c0d0794b50e3b638cca4bed925638ab68bc] | committer: Ronald S. Bultje
> >>>> 
> >>>> dsputil: set STRIDE_ALIGN to 16 for x86 also.
> >>>> 
> >>>> This fixes crashes in e.g. PNG decoding with SSE2 enabled. In fact, many
> >>>> x86 optimizations for codecs assume that our buffer strides are 16-byte
> >>>> aligned.
> >>> 
> >>> With that merged you probably should revert my pngdsp changes.
> >> 
> >> who is "you" in there ?
> >> i doubt a bit ronald is going to revert it ;)
> > 
> > If you want i can revert it but i think ronalds changes did not
> > completely fix this so its more than a simple git revert.
> 
> I meant you. If you think it doesn't completely fix it and unaligned mov is still required then of course forget it (and it should only be that one remaining, the swapped mov is fixed).

i think the aligned mov might be ok now but reverting the w/waq change
will break the file.

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The educated differ from the uneducated as much as the living from the
dead. -- Aristotle 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-cvslog/attachments/20120210/97e0e554/attachment.asc>


More information about the ffmpeg-cvslog mailing list