[FFmpeg-cvslog] matroskadec: properly fall back to generic seek.
Reimar.Doeffinger at gmx.de
Mon Feb 13 21:28:48 CET 2012
On Mon, Feb 13, 2012 at 09:06:31PM +0100, Michael Niedermayer wrote:
> On Mon, Feb 13, 2012 at 08:05:12PM +0100, Reimar Döffinger wrote:
> > ffmpeg | branch: master | Reimar Döffinger <Reimar.Doeffinger at gmx.de> | Sun Feb 12 14:09:03 2012 +0100| [47e015e6f1913f7da943898eb7716a954f947ff7] | committer: Reimar Döffinger
> > matroskadec: properly fall back to generic seek.
> > In particular, detect when the index is obviously broken.
> > This fixes the worst symptoms of trac issue #958 and makes
> > sense to allow seeking in files without index.
> > However it is possible that there still is an index parsing bug
> > with that file.
> > Signed-off-by: Reimar Döffinger <Reimar.Doeffinger at gmx.de>
> either this or the previous commit broke fate: (seektest)
This one. I must have forgotten to run the test once more
after some last changes.
But do you think the new result is wrong?
Previously it would say "seek ok" and then immediately return EOF
on the next read, now the seek will fail directly (if I read the
Behaviour seems a bit inconsistent, but only these behave the way
mkv did before, so the majority seem to agree with the new behaviour:
More information about the ffmpeg-cvslog