[FFmpeg-cvslog] electronicarts: Let functions always returning the same value return void

Michael Niedermayer michaelni at gmx.at
Sun Aug 18 02:44:38 CEST 2013


On Sat, Aug 17, 2013 at 03:00:27PM +0200, Alexander Strasser wrote:
> Hi all,
> 
>   I hope it is not too annoying, but I do *not* plan to keep quiet
> when I see things like this!
> 
> On 2013-08-16 12:31 +0200, Diego Biurrun wrote:
> > ffmpeg | branch: master | Diego Biurrun <diego at biurrun.de> | Wed Aug 14 18:04:36 2013 +0200| [163a729725c6eb0081b0af41a7279f7d19aee86e] | committer: Diego Biurrun
> > 
> > electronicarts: Let functions always returning the same value return void
> 
>   The comments that were removed before this patch, clearly indicated
> a system the original author of the code had in mind.
> 
>   As far as I can see, this patch fixes nothing and to me even makes
> the code structurally less clear.
> 

>   I would like to see the comments restored and this commit reverted.
> What do others think?

iam fine with whatever the author / maintainer prefers

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Concerning the gods, I have no means of knowing whether they exist or not
or of what sort they may be, because of the obscurity of the subject, and
the brevity of human life -- Protagoras
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-cvslog/attachments/20130818/e490cb64/attachment.asc>


More information about the ffmpeg-cvslog mailing list