[FFmpeg-cvslog] ffv1enc: Check the return value of ffv1_common_init()

Clément Bœsch ubitux at gmail.com
Sat May 11 20:56:44 CEST 2013


On Sat, May 11, 2013 at 08:51:38PM +0200, Michael Niedermayer wrote:
> ffmpeg | branch: master | Michael Niedermayer <michaelni at gmx.at> | Sat May 11 20:17:09 2013 +0200| [54602590d9e479e474db75cafa2e4b9f2799eafe] | committer: Michael Niedermayer
> 
> ffv1enc: Check the return value of ffv1_common_init()
> 
> Signed-off-by: Michael Niedermayer <michaelni at gmx.at>
> 
> > http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=54602590d9e479e474db75cafa2e4b9f2799eafe
> ---
> 
>  libavcodec/ffv1enc.c |    3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/libavcodec/ffv1enc.c b/libavcodec/ffv1enc.c
> index 79e483d..4535464 100644
> --- a/libavcodec/ffv1enc.c
> +++ b/libavcodec/ffv1enc.c
> @@ -641,7 +641,8 @@ static av_cold int encode_init(AVCodecContext *avctx)
>      const AVPixFmtDescriptor *desc = av_pix_fmt_desc_get(avctx->pix_fmt);
>      int i, j, k, m, ret;
>  
> -    ffv1_common_init(avctx);
> +    if ((ret = ffv1_common_init(avctx)) < ret)

Wut?

Don't you mean < 0?

> +        return ret;
>  
>      s->version = 0;
>  

-- 
Clément B.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 490 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-cvslog/attachments/20130511/ce4ccf3b/attachment.asc>


More information about the ffmpeg-cvslog mailing list